Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo #813

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Fixed typo #813

merged 1 commit into from
Jul 7, 2022

Conversation

PrajwalBorkar
Copy link
Contributor

Signed-off-by: Prajwal Borkar prajwalborkar5075@gmail.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Fixed typo in core-concepts.md file

Related Issues

Fixes #778

New Behavior (screenshots if needed)

@aFlyBird0
Copy link
Member

Thank you for your second pr! ✊

DevStream community follows the conventional commits specification. Please read our doc .

The right commit message could be : docs: fix typo.

You can choose to update this commit message and use git push -f to overide old commits. Or, do nothing and let us change commit messages when we merge it.

@aFlyBird0 aFlyBird0 self-requested a review July 5, 2022 10:04
@aFlyBird0
Copy link
Member

Could you please start a review? @HXCGIT Thanks a lot! (please pay attention to commit messages)

@xavier-hou xavier-hou self-requested a review July 5, 2022 10:06
@aFlyBird0
Copy link
Member

The "Code Owner" of this part is IronCore. He must approve pr before it can be merged, please be patient. @PrajwalBorkar
image

Signed-off-by: Prajwal Borkar <prajwalborkar5075@gmail.com>
@IronCore864 IronCore864 merged commit cbc3dfe into devstream-io:main Jul 7, 2022
@PrajwalBorkar PrajwalBorkar deleted the prajwal-patch1 branch July 7, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📖 Docs: Spelling errors in core-concept.md
4 participants